Master/SpaceNinjaServer
1
0
Fork 0
forked from OpenWF/SpaceNinjaServer
Code Pull Requests Activity

chore: fix unsafe member access warnings for upgrade fingerprints (#653)

Browse Source
This commit is contained in:
Sainan 2024-12-29 21:40:38 +01:00 committed by GitHub
parent 8a4f2f4d0e
commit 00bcf5c3c5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/controllers/api/arcaneCommonController.ts
View File

@ -19,7 +19,7 @@ export const arcaneCommonController: RequestHandler = async (req, res) => {
inventory.Upgrades.pull({ _id: json.arcane.ItemId.$oid }); inventory.Upgrades.pull({ _id: json.arcane.ItemId.$oid });
// Add RawUpgrades // Add RawUpgrades
const numRawUpgradesToGive = arcaneLevelCounts[JSON.parse(upgrade.UpgradeFingerprint).lvl]; const numRawUpgradesToGive = arcaneLevelCounts[(JSON.parse(upgrade.UpgradeFingerprint) as { lvl: number }).lvl];
addMods(inventory, [ addMods(inventory, [
{ {
ItemType: json.arcane.ItemType, ItemType: json.arcane.ItemType,
@ -35,7 +35,7 @@ export const arcaneCommonController: RequestHandler = async (req, res) => {
if (upgrade) { if (upgrade) {
// Have an existing Upgrade item? // Have an existing Upgrade item?
if (upgrade.UpgradeFingerprint) { if (upgrade.UpgradeFingerprint) {
const existingLevel = JSON.parse(upgrade.UpgradeFingerprint).lvl; const existingLevel = (JSON.parse(upgrade.UpgradeFingerprint) as { lvl: number }).lvl;
numConsumed -= arcaneLevelCounts[existingLevel]; numConsumed -= arcaneLevelCounts[existingLevel];
} }
upgrade.UpgradeFingerprint = JSON.stringify({ lvl: json.newRank }); upgrade.UpgradeFingerprint = JSON.stringify({ lvl: json.newRank });

3
src/services/inventoryService.ts
View File

@ -905,8 +905,7 @@ export const upgradeMod = async (artifactsData: IArtifactsRequest, accountId: st
const { ItemType, UpgradeFingerprint, ItemId } = Upgrade; const { ItemType, UpgradeFingerprint, ItemId } = Upgrade;
const safeUpgradeFingerprint = UpgradeFingerprint || '{"lvl":0}'; const safeUpgradeFingerprint = UpgradeFingerprint || '{"lvl":0}';
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment const parsedUpgradeFingerprint = JSON.parse(safeUpgradeFingerprint) as { lvl: number };
const parsedUpgradeFingerprint = JSON.parse(safeUpgradeFingerprint);
parsedUpgradeFingerprint.lvl += LevelDiff; parsedUpgradeFingerprint.lvl += LevelDiff;
const stringifiedUpgradeFingerprint = JSON.stringify(parsedUpgradeFingerprint); const stringifiedUpgradeFingerprint = JSON.stringify(parsedUpgradeFingerprint);