From 02ce0f57a6b1954f38a4831da591a51b173ebc46 Mon Sep 17 00:00:00 2001
From: Sainan <sainan@calamity.inc>
Date: Wed, 12 Mar 2025 05:10:26 -0700
Subject: [PATCH] chore: faithful response to getGuild & getGuildLog when not
 in a clan (#1159)

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1159
---
 src/controllers/api/getGuildController.ts    |  2 +-
 src/controllers/api/getGuildLogController.ts | 18 ++++++++++--------
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/src/controllers/api/getGuildController.ts b/src/controllers/api/getGuildController.ts
index 9dcfcbf1d..0b7c5a95a 100644
--- a/src/controllers/api/getGuildController.ts
+++ b/src/controllers/api/getGuildController.ts
@@ -28,7 +28,7 @@ const getGuildController: RequestHandler = async (req, res) => {
             return;
         }
     }
-    res.json({});
+    res.sendStatus(200);
 };
 
 export { getGuildController };
diff --git a/src/controllers/api/getGuildLogController.ts b/src/controllers/api/getGuildLogController.ts
index ab19f5e14..245d857e3 100644
--- a/src/controllers/api/getGuildLogController.ts
+++ b/src/controllers/api/getGuildLogController.ts
@@ -6,18 +6,18 @@ import { IMongoDate } from "@/src/types/commonTypes";
 import { RequestHandler } from "express";
 
 export const getGuildLogController: RequestHandler = async (req, res) => {
-    const log: Record<string, IGuildLogEntryClient[]> = {
-        RoomChanges: [],
-        TechChanges: [],
-        RosterActivity: [],
-        StandingsUpdates: [],
-        ClassChanges: []
-    };
     const accountId = await getAccountIdForRequest(req);
     const inventory = await getInventory(accountId);
     if (inventory.GuildId) {
         const guild = await Guild.findOne({ _id: inventory.GuildId });
         if (guild) {
+            const log: Record<string, IGuildLogEntryClient[]> = {
+                RoomChanges: [],
+                TechChanges: [],
+                RosterActivity: [],
+                StandingsUpdates: [],
+                ClassChanges: []
+            };
             guild.ClassChanges?.forEach(entry => {
                 log.ClassChanges.push({
                     dateTime: toMongoDate(entry.dateTime),
@@ -25,9 +25,11 @@ export const getGuildLogController: RequestHandler = async (req, res) => {
                     details: entry.details
                 });
             });
+            res.json(log);
+            return;
         }
     }
-    res.json(log);
+    res.sendStatus(200);
 };
 
 interface IGuildLogEntryClient {