From 53ce6ccce2767f487aedd5b30a37bbf58aeb2e07 Mon Sep 17 00:00:00 2001
From: Sainan <sainan@calamity.inc>
Date: Sat, 1 Feb 2025 07:32:56 -0800
Subject: [PATCH] fix: subtract standing gained in missions from daily bin
 (#880)

Fixes #794

Reviewed-on: http://209.141.38.3/OpenWF/SpaceNinjaServer/pulls/880
Co-authored-by: Sainan <sainan@calamity.inc>
Co-committed-by: Sainan <sainan@calamity.inc>
---
 src/services/inventoryService.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/services/inventoryService.ts b/src/services/inventoryService.ts
index 594c2847..30c1acd4 100644
--- a/src/services/inventoryService.ts
+++ b/src/services/inventoryService.ts
@@ -41,6 +41,7 @@ import {
     ExportRecipes,
     ExportResources,
     ExportSentinels,
+    ExportSyndicates,
     ExportUpgrades,
     ExportWeapons,
     TStandingLimitBin
@@ -1054,12 +1055,11 @@ export const addBooster = (ItemType: string, time: number, inventory: TInventory
 export const updateSyndicate = (
     inventory: HydratedDocument<IInventoryDatabase, InventoryDocumentProps>,
     syndicateUpdate: IMissionInventoryUpdateRequest["AffiliationChanges"]
-) => {
+): void => {
     syndicateUpdate?.forEach(affiliation => {
         const syndicate = inventory.Affiliations.find(x => x.Tag == affiliation.Tag);
         if (syndicate !== undefined) {
-            syndicate.Standing =
-                syndicate.Standing === undefined ? affiliation.Standing : syndicate.Standing + affiliation.Standing;
+            syndicate.Standing += affiliation.Standing;
             syndicate.Title = syndicate.Title === undefined ? affiliation.Title : syndicate.Title + affiliation.Title;
         } else {
             inventory.Affiliations.push({
@@ -1070,8 +1070,8 @@ export const updateSyndicate = (
                 FreeFavorsUsed: []
             });
         }
+        updateStandingLimit(inventory, ExportSyndicates[affiliation.Tag].dailyLimitBin, affiliation.Standing);
     });
-    return { AffiliationMods: [] };
 };
 
 /**