From 3194a693b37560cfc806c8edd9f3b9d70b6dc310 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Wed, 13 Aug 2025 07:13:41 -0700 Subject: [PATCH] fix: hardcode rotation A for non-endless railjack missions (#2613) Closes #2612 Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/2613 Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com> Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com> --- src/services/missionInventoryUpdateService.ts | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index 7e946df2..7cc71a0e 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -97,17 +97,21 @@ const getRotations = (rewardInfo: IRewardInfo, tierOverride?: number): number[] return rotations; } - // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition - const missionIndex: number | undefined = ExportRegions[rewardInfo.node]?.missionIndex; + const region = ExportRegions[rewardInfo.node] as IRegion | undefined; + const missionIndex: number | undefined = region?.missionIndex; // For Rescue missions if (missionIndex == 3 && rewardInfo.rewardTier) { return [rewardInfo.rewardTier]; } - // 'rewardQualifications' is unreliable for mission types that only have rotation A (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/2586) - if (missionIndex == 0 || missionIndex == 1 || missionIndex == 5) { - return [0]; + // 'rewardQualifications' is unreliable for non-endless railjack missions (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/2586, https://onlyg.it/OpenWF/SpaceNinjaServer/issues/2612) + switch (region?.missionName) { + case "/Lotus/Language/Missions/MissionName_Railjack": + case "/Lotus/Language/Missions/MissionName_RailjackVolatile": + case "/Lotus/Language/Missions/MissionName_RailjackExterminate": + case "/Lotus/Language/Missions/MissionName_RailjackAssassinate": + return [0]; } const rotationCount = rewardInfo.rewardQualifications?.length || 0;