AMelonInsideLemon/SpaceNinjaServer
1
0
Fork 0
forked from OpenWF/SpaceNinjaServer
Code Pull Requests Activity

fix: junction completion on steel path doesn't save (#2937)

Browse Source 
Aka., an alternative approach to fixing the problem in #2866. Junctions don't have RewardInfo and therefore weren't reaching the new call to addMissionComplete.

Reviewed-on: OpenWF/SpaceNinjaServer#2937
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
This commit is contained in:
Sainan 2025-10-25 00:27:02 -07:00 committed by Sainan
parent 0d21c73ab7
commit 23abe5de02
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/inventoryService.ts
View File

@ -2180,7 +2180,7 @@ export const addMissionComplete = (inventory: TInventoryDatabaseDocument, { Tag,
if (itemIndex !== -1) { if (itemIndex !== -1) {
Missions[itemIndex].Completes += Completes; Missions[itemIndex].Completes += Completes;
if (Tier) { if (Completes && Tier) {
Missions[itemIndex].Tier = Tier; Missions[itemIndex].Tier = Tier;
} }
} else { } else {

6
src/services/missionInventoryUpdateService.ts
View File

@ -310,6 +310,9 @@ export const addMissionInventoryUpdates = async (
} }
break; break;
} }
case "Missions":
addMissionComplete(inventory, value);
break;
case "LastRegionPlayed": case "LastRegionPlayed":
if (!(config.unfaithfulBugFixes?.ignore1999LastRegionPlayed && value === "1999MapName")) { if (!(config.unfaithfulBugFixes?.ignore1999LastRegionPlayed && value === "1999MapName")) {
inventory.LastRegionPlayed = value; inventory.LastRegionPlayed = value;
@ -1242,9 +1245,6 @@ export const addMissionRewards = async (
if (missions && missions.Tag in ExportRegions) { if (missions && missions.Tag in ExportRegions) {
const node = ExportRegions[missions.Tag]; const node = ExportRegions[missions.Tag];
// cannot add this with normal updates because { Tier: 1 } would mark the SP node as completed even on a failure
addMissionComplete(inventory, missions);
//node based credit rewards for mission completion //node based credit rewards for mission completion
if (isEligibleForCreditReward(rewardInfo, missions, node)) { if (isEligibleForCreditReward(rewardInfo, missions, node)) {
const levelCreditReward = getLevelCreditRewards(node); const levelCreditReward = getLevelCreditRewards(node);